linux-kernel - Re: [PATCH] mfd: asic3: fix asic3_gpio_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120416165810.GR24130@sortiz-mobl>
Date:	Mon, 16 Apr 2012 18:58:10 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Dmitry Artamonow <mad_soft@...ox.ru>
Cc:	Paul Parsons <lost.distance@...oo.com>,
	Philipp Zabel <philipp.zabel@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: asic3: fix asic3_gpio_to_irq

Hi Dmitry,

On Thu, Apr 12, 2012 at 03:33:34PM +0400, Dmitry Artamonow wrote:
> Assumption that irq numbers of asic3 gpios start at
> IRQ_BOARD_START is certainly wrong - driver may as well
> use any other base for its irqs (consider for example
> the imaginary case of two ASIC3 chips onboard)
> 
> Furthermore, some platforms even don't have IRQ_BOARD_START
> defined, so driver will fail to build on them:
> -------------------------------------------------------
> drivers/mfd/asic3.c: In function 'asic3_gpio_to_irq':
> drivers/mfd/asic3.c:530: error: 'IRQ_BOARD_START' undeclared (first use in this function)
> drivers/mfd/asic3.c:530: error: (Each undeclared identifier is reported only once
> drivers/mfd/asic3.c:530: error: for each function it appears in.)
> -------------------------------------------------------
> 
> Fix it by using irq_base from driver data.
> 
> Signed-off-by: Dmitry Artamonow <mad_soft@...ox.ru>
> ---
>  drivers/mfd/asic3.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
Thanks, I applied this one to my for-linus branch.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/