linux-kernel - Re: Please fix or revert: [PATCH] checkpatch: add --strict tests for braces, comments and casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Apr 2012 12:09:12 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	mingo@...nel.org, joe@...ches.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, apw@...onical.com
Subject: Re: Please fix or revert: [PATCH] checkpatch: add --strict tests for
 braces, comments and casts

On Mon, Apr 16, 2012 at 11:27 AM, David Miller <davem@...emloft.net> wrote:
>
> I would like to formally propose that we change CodingStyle so that
> our comments are of the form:
>
>        /* XXX
>         * YYY
>         */
>
> So that we can save one line of vertical space.

Ugh, I personally hate it. No way will we make that the recommended
version, even if it might be an acceptable substitute in some
subsystems.

It looks unbalanced. If you want to save that vertical space, just use
C++ style comments instead, for chissake! Then you save *two* lines,
without the unbalanced thing, and just write it as

    // XXX
    // YYY

which is much preferred.

Your suggested format just sucks, and has the worst of all worlds.

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/