linux-kernel - Re: Please fix or revert: [PATCH] checkpatch: add --strict tests for braces, comments and casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Apr 2012 14:34:47 -0600
From:	Joe Perches <joe@...ches.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	apw@...onical.com
Subject: Re: Please fix or revert: [PATCH] checkpatch: add --strict tests
 for braces, comments and casts

On Mon, 2012-04-16 at 22:26 +0200, Ingo Molnar wrote:
>  1) It's butt ugly and it violates every basic principle of
>     typography. Saving a line is often counter-productive, a 
>     well placed whitespace (vertical or horizontal) will often 
>     increase readability. Key is good balance.

True enough.

>     If you don't "see" it as ugly it's simply because your brain
>     is not wired up to see 3D/2D geometry as a significant
>     source of information. A significant portion (I'd 
>     guesstimate a narrow majority) of kernel hackers *does* see
>     2D/3D layout details in code and finds inconsistencies in 
>     them counterproductive.

I believe there's an empty hat somewhere that must
have produced this email.

I rather doubt anyone "sees" 3d geometries out of
a coding style.  Otherwise, cite please...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/