linux-kernel - Re: [PATCH 2/4] input: Device tree support for LPC32xx touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120416061645.GC3037@avionic-0098.adnet.avionic-design.de>
Date:	Mon, 16 Apr 2012 08:16:45 +0200
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Roland Stigge <stigge@...com.de>
Cc:	arm@...nel.org, linux-arm-kernel@...ts.infradead.org,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	dmitry.torokhov@...il.com, axel.lin@...il.com,
	broonie@...nsource.wolfsonmicro.com, marek.vasut@...il.com,
	devel@...verdev.osuosl.org, kevin.wells@....com,
	srinivas.bakki@....com
Subject: Re: [PATCH 2/4] input: Device tree support for LPC32xx touchscreen

* Roland Stigge wrote:
> This patch adds device tree support for the LPC32xx SoC's touchscreen
> controller.
> 
> Signed-off-by: Roland Stigge <stigge@...com.de>
> 
> ---
> 
>  Applies to v3.4-rc2
> 
>  Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt |   16 ++++++++++
>  drivers/input/touchscreen/lpc32xx_ts.c                              |   10 ++++++
>  2 files changed, 26 insertions(+)
> 
> --- /dev/null
> +++ linux-2.6/Documentation/devicetree/bindings/input/touchscreen/lpc32xx-tsc.txt
> @@ -0,0 +1,16 @@
> +* NXP LPC32xx SoC Touchscreen Controller (TSC)
> +
> +Required properties:
> +- compatible: must be "nxp,lpc32xx-tsc"
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +- interrupts: The TSC/ADC interrupt
> +
> +Example:
> +
> +	tsc@...48000 {
> +		compatible = "nxp,lpc32xx-tsc";
> +		reg = <0x40048000 0x1000>;
> +		interrupt-parent = <&mic>;
> +		interrupts = <39 0>;
> +	};
> --- linux-2.6.orig/drivers/input/touchscreen/lpc32xx_ts.c
> +++ linux-2.6/drivers/input/touchscreen/lpc32xx_ts.c
> @@ -22,6 +22,7 @@
>  #include <linux/clk.h>
>  #include <linux/io.h>
>  #include <linux/slab.h>
> +#include <linux/of.h>
>  
>  /*
>   * Touchscreen controller register offsets
> @@ -383,6 +384,14 @@ static const struct dev_pm_ops lpc32xx_t
>  #define LPC32XX_TS_PM_OPS NULL
>  #endif
>  
> +#ifdef CONFIG_OF
> +static struct of_device_id lpc32xx_tsc_of_match[] = {
> +	{ .compatible = "nxp,lpc32xx-tsc", },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, lpc32xx_tsc_of_match);
> +#endif
> +
>  static struct platform_driver lpc32xx_ts_driver = {
>  	.probe		= lpc32xx_ts_probe,
>  	.remove		= __devexit_p(lpc32xx_ts_remove),
> @@ -390,6 +399,7 @@ static struct platform_driver lpc32xx_ts
>  		.name	= MOD_NAME,
>  		.owner	= THIS_MODULE,
>  		.pm	= LPC32XX_TS_PM_OPS,
> +		.of_match_table = of_match_ptr(lpc32xx_tsc_of_match),
>  	},
>  };
>  module_platform_driver(lpc32xx_ts_driver);

Reviewed-by: Thierry Reding <thierry.reding@...onic-design.de>

Content of type "application/pgp-signature" skipped