linux-kernel - Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F8CC683.7060908@xenotime.net>
Date:	Mon, 16 Apr 2012 18:25:23 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org, Tim Hockin <thockin@....com>
Subject: Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled

On 04/16/2012 03:20 PM, Paul Gortmaker wrote:

> On Mon, Apr 16, 2012 at 3:50 PM, Randy Dunlap <rdunlap@...otime.net> wrote:
>> From: Randy Dunlap <rdunlap@...otime.net>
>>
>> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
> 
> Minor nit -- above line and subject reference sbc2, when fail comes
> from scb2 source module.

Ack.  I noticed later that I had botched that.

Thanks.

> Paul.
> --
> 
>> is not enabled, so make it depend on PCI.
>>
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
>> Cc:     David Woodhouse <dwmw2@...radead.org>
>> Cc:     linux-mtd@...ts.infradead.org
>> ---
>>  drivers/mtd/maps/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20120416.orig/drivers/mtd/maps/Kconfig
>> +++ linux-next-20120416/drivers/mtd/maps/Kconfig
>> @@ -224,7 +224,7 @@ config MTD_CK804XROM
>>
>>  config MTD_SCB2_FLASH
>>        tristate "BIOS flash chip on Intel SCB2 boards"
>> -       depends on X86 && MTD_JEDECPROBE
>> +       depends on X86 && MTD_JEDECPROBE && PCI
>>        help
>>          Support for treating the BIOS flash chip on Intel SCB2 boards
>>          as an MTD device - with this you can reprogram your BIOS.
>> --


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/