linux-kernel - Re: [PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Apr 2012 08:59:46 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-mmc@...r.kernel.org, cjb@...top.org
Subject: Re: [PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol
 prototypes

Hi Hartley

Thanks for the patch.

On Mon, 16 Apr 2012, H Hartley Sweeten wrote:

> Include the linux/mmc/cd-gpio.h header to pickup the prototypes
> for the two exported symbols.
> 
> This quiets the sparse warnings:
> 
> warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
> warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Chris Ball <cjb@...top.org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@....de>
> 
> ---
> 
> diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
> index 29de31e..da7c3f9 100644
> --- a/drivers/mmc/core/cd-gpio.c
> +++ b/drivers/mmc/core/cd-gpio.c
> @@ -13,6 +13,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/jiffies.h>
>  #include <linux/mmc/host.h>
> +#include <linux/mmc/cd-gpio.h>

Call me a pettyfogger, but please put the header above mmc/host.h, please, 
keep the alphabetic order.

>  #include <linux/module.h>
>  #include <linux/slab.h>
>  

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/