linux-kernel - [PATCH linux-next] mm/hugetlb: fix warning in alloc_huge_page/dequeue_huge_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Apr 2012 16:28:19 +0400
From:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Mel Gorman <mgorman@...e.de>
Subject: [PATCH linux-next] mm/hugetlb: fix warning in
 alloc_huge_page/dequeue_huge_page_vma

This patch fixes gcc warning (and bug?) introduced in linux-next commit cc9a6c877
("cpuset: mm: reduce large amounts of memory barrier related damage v3")

Local variable "page" can be uninitialized if nodemask from vma policy does not
intersects with nodemask from cpuset. Even if it wouldn't happens it's better to
initialize this variable explicitly than to introduce kernel oops on weird corner case.

mm/hugetlb.c: In function ‘alloc_huge_page’:
mm/hugetlb.c:1135:5: warning: ‘page’ may be used uninitialized in this function

Signed-off-by: Konstantin Khlebnikov <khlebnikov@...nvz.org>
Cc: Mel Gorman <mgorman@...e.de>
---
 mm/hugetlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 4314a88..dcf4a55 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -532,7 +532,7 @@ static struct page *dequeue_huge_page_vma(struct hstate *h,
 				struct vm_area_struct *vma,
 				unsigned long address, int avoid_reserve)
 {
-	struct page *page;
+	struct page *page = NULL;
 	struct mempolicy *mpol;
 	nodemask_t *nodemask;
 	struct zonelist *zonelist;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/