linux-kernel - Re: [PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Apr 2012 14:53:12 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Valentin Ilie <valentin.ilie@...il.com>
Cc:	geoff@...radead.org, linuxppc-dev@...ts.ozlabs.org,
	cbe-oss-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings

On Tue, Apr 17, 2012 at 13:16, Valentin Ilie <valentin.ilie@...il.com> wrote:
> diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c
> index a409fa0..46136b0 100644
> --- a/drivers/ps3/ps3av.c
> +++ b/drivers/ps3/ps3av.c
> @@ -25,8 +25,8 @@
>  #include <linux/ioctl.h>
>  #include <linux/fb.h>
>  #include <linux/slab.h>
> +#include <linux/firmware.h>
>
> -#include <asm/firmware.h>

NAK. It really needs <asm/firmware.h> (have you compiled the result?).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/