linux-kernel - Re: [alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120417134351.GD6652@opensource.wolfsonmicro.com>
Date:	Tue, 17 Apr 2012 14:43:52 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ashish Chavan <ashish.chavan@...tcummins.com>
Cc:	lrg <lrg@...com>, alsa-devel <alsa-devel@...a-project.org>,
	David Dajun Chen <david.chen@...semi.com>,
	"kuninori.morimoto.gx" <kuninori.morimoto.gx@...esas.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM

On Tue, Apr 17, 2012 at 06:04:06PM +0530, Ashish Chavan wrote:

> +	/* Search pll div array for correct divisors */
> +	for (cnt = 0; cnt < ARRAY_SIZE(da7210_pll_div); cnt++) {
> +		/* check fref */
> +		if (fref == da7210_pll_div[cnt].fref) {
> +			/* check mode */
> +			 if (da7210->master ==  da7210_pll_div[cnt].mode) {
> +				/* check fout */
> +				if (fout == da7210_pll_div[cnt].fout) {

I've applied but this would be a lot clearer if it were writen as a
single if statement with &&s.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)