linux-kernel - Re: linux-next: build failure after merge of the final tree (security tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Apr 2012 12:02:33 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	James Morris <jmorris@...ei.org>
Cc:	Will Drewry <wad@...omium.org>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	Eric Paris <eparis@...hat.com>,
	Kees Cook <keescook@...omium.org>
Subject: Re: linux-next: build failure after merge of the final tree
 (security tree related)

Hi James,

On Tue, 17 Apr 2012 11:33:26 +1000 (EST) James Morris <jmorris@...ei.org> wrote:
>
> On Mon, 16 Apr 2012, Will Drewry wrote:
> 
> > >> arch/powerpc/kernel/ptrace.c: In function 'do_syscall_trace_enter':
> > >> arch/powerpc/kernel/ptrace.c:1713:2: error: statement with no effect [-Werror=unused-value]
> > >> cc1: all warnings being treated as errors
> 
> Is this happening because of
> 
> 	#define secure_computing(x) 0
> 
> ?
>
> In any case, that should probably be a static inline.

That could well be so - sorry I missed that.  The failure was in an
allnoconfig build, so CONFIG_SECCOMP was off.

And yes, changing that to:

static inline int secure_computing(int this_syscall) { return 0; }

fixes the build problem.  So that is a better fix.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped