linux-kernel - Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120417142105.GA21802@pengutronix.de>
Date:	Tue, 17 Apr 2012 16:21:05 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Zhao Chenhui <chenhui.zhao@...escale.com>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Li Yang <leoli@...escale.com>
Subject: Re: [PATCH] i2c-mpc: avoid I2C abnormal after resuming from deep
 sleep

On Wed, Feb 29, 2012 at 07:45:23PM +0100, Wolfram Sang wrote:
> Hi,
> 
> On Wed, Feb 29, 2012 at 06:39:21PM +0800, Zhao Chenhui wrote:
> > When entering deep sleep, the value in the registers I2CFDR and
> > I2CDFSRR are lost. This causes I2C access to fail after resuming.
> > 
> > Add suspend/resume routines to save/restore the registers
> > I2CFDR and I2CDFSRR.
> > 
> > Signed-off-by: Zhao Chenhui <chenhui.zhao@...escale.com>
> > Signed-off-by: Li Yang <leoli@...escale.com>
> > ---
> >  drivers/i2c/busses/i2c-mpc.c |   34 +++++++++++++++++++++++++++++++++-
> >  1 files changed, 33 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> > index a8ebb84..f95a647 100644
> > --- a/drivers/i2c/busses/i2c-mpc.c
> > +++ b/drivers/i2c/busses/i2c-mpc.c
> > @@ -1,7 +1,9 @@
> >  /*
> >   * (C) Copyright 2003-2004
> >   * Humboldt Solutions Ltd, adrian@...boldt.co.uk.
> > -
> > + *
> > + * Copyright 2012 Freescale Semiconductor, Inc.
> > + *
> 
> I'd think the change is too trivial to claim copyright on the file.

Do you want to resend with the comments addressed?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)