linux-kernel - Re: [PATCH 2/4] Add Wolfson Microelectronics WM8766 codec ALSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Apr 2012 15:59:29 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] Add Wolfson Microelectronics WM8766 codec ALSA
 driver

On Mon, Apr 16, 2012 at 11:18:36PM +0200, Ondrej Zary wrote:
> Needed by Philips PSC724 subdriver. The code does not contain any
> card-specific bits so it can be used by any other ALSA driver.
> 
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>

Please CC me (and ideally all of patches@...nsource.wolfsonmicro.com)
on any drivers for Wolfson devices.  It's not like we're secretive!

> ---
>  include/sound/wm8766.h   |  160 ++++++++++++++++++++
>  sound/i2c/other/Makefile |    3 +-
>  sound/i2c/other/wm8766.c |  374 ++++++++++++++++++++++++++++++++++++++++++++++

No, this should be supported in ASoC - anything adding new code in
sound/i2c is *deeply* suspicious.

> +struct snd_wm8766_ops {
> +	void (*write)(struct snd_wm8766 *wm, u16 addr, u16 data);
> +};

You should in general use regmap rather than open coding register I/O
for I2C devices.

> +void snd_wm8766_init(struct snd_wm8766 *wm);
> +void snd_wm8766_set_if(struct snd_wm8766 *wm, u16 dac);
> +void snd_wm8766_set_master_mode(struct snd_wm8766 *wm, u16 mode);
> +void snd_wm8766_set_power(struct snd_wm8766 *wm, u16 power);
> +void snd_wm8766_volume_restore(struct snd_wm8766 *wm);
> +int snd_wm8766_build_controls(struct snd_wm8766 *wm);

I've not yet looked at the rest of the code but this looks awfully like
you've just invented a minimal version of the ASoC interfaces...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/