linux-kernel - Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1334677936.4965.13.camel@cumari>
Date:	Tue, 17 Apr 2012 18:52:16 +0300
From:	Luciano Coelho <coelho@...com>
To:	Randy Dunlap <rdunlap@...otime.net>, johannes@...solutions.net
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-wireless@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

On Tue, 2012-04-17 at 11:29 -0700, Randy Dunlap wrote: 
> On 04/16/2012 10:30 PM, Luciano Coelho wrote:
> 
> > Hi Randy,
> > 
> > On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote: 
> >> From: Randy Dunlap <rdunlap@...otime.net>
> >>
> >> wl12xx build fails with many undefined symbol errors when MAC80211
> >> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> >> on MAC80211 (which already depends on CFG80211).
> >>
> >> Here are a few of the many build errors:
> >>
> > 
> > [...]
> > 
> >> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> >> Cc:	Luciano Coelho <coelho@...com>
> >> Cc:	linux-wireless@...r.kernel.org
> >> Cc:	"John W. Linville" <linville@...driver.com>
> >> ---
> > 
> > Thanks for the patch!
> > 
> > 
> >> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
> >> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
> >> @@ -1,5 +1,6 @@
> >>  config WL12XX
> >>         tristate "TI wl12xx support"
> >> +	depends on MAC80211
> >>         select WLCORE
> > 
> > Do we really need this one? wl12xx selects WLCORE which in turn depends
> > on MAC80211 (with your change below).  Maybe we don't need this?
> 
> Hi,
> 
> [testing...]
> 
> The build fails if either one of these "depends" is omitted.

Yeah, thanks for testing.  I guess it's because, as Johannes said,
select doesn't check the dependencies of the selected module.

Johannes, thanks for the explanation.


-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/