linux-kernel - Re: [REGRESSION] rtc/interface.c: kills suspend-to-ram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F8CD4FC.6020006@teksavvy.com>
Date:	Mon, 16 Apr 2012 22:27:08 -0400
From:	Mark Lord <kernel@...savvy.com>
To:	John Stultz <john.stultz@...aro.org>
CC:	richard -rw- weinberger <richard.weinberger@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Greg Kroah-Hartman <greg@...ah.com>, stable@...r.kernel.org
Subject: Re: [REGRESSION] rtc/interface.c: kills suspend-to-ram

On 12-04-16 03:44 PM, John Stultz wrote:
> On 04/16/2012 07:23 AM, richard -rw- weinberger wrote:
>> On Mon, Apr 16, 2012 at 3:55 PM, Mark Lord<kernel@...savvy.com>  wrote:
>>> Speaking of which -- that batch of RTC updates is riddled with bugs.
>>> For example, this beauty from rtc-mpc5121.c in the same update:
>>>
>>>         ...
>>>         rtc->rtc = rtc_device_register("mpc5200-rtc",&op->dev,
>>>                                         &mpc5200_rtc_ops, THIS_MODULE);
>>>         ...
>>>
>>>         rtc->rtc->uie_unsupported = 1;    //<<<<  Ooops NULL pointer>>>>
>>>
>>>         if (IS_ERR(rtc->rtc)) {           //<<<<  this needs to be earlier>>>>
>>>                 err = PTR_ERR(rtc->rtc);
>>>                 goto out_free_irq;
>>>         }
>>>         ...
>>>
>>>
> 
> Thanks for noticing this and CC'ing me.  I'll spin up a fix promptly for review.
> -john

Yeah.  My apologies for being so harsh there.
At least the fix is easy enough.

Cheers!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/