linux-kernel - Re: [alsa-devel] [PATCH 3/4] Add Wolfson Microelectronics WM8776 codec ALSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hbomqpafy.wl%tiwai@suse.de>
Date:	Tue, 17 Apr 2012 18:52:49 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Ondrej Zary <linux@...nbow-software.org>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH 3/4] Add Wolfson Microelectronics WM8776 codec ALSA driver

At Tue, 17 Apr 2012 17:50:06 +0100,
Mark Brown wrote:
> 
> On Tue, Apr 17, 2012 at 06:32:18PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > What makes you cleaim that "ASoC was not designed to be used with sound
> > > cards"?  Implementing sound cards is the sole purpose of ASoC...
> 
> > You don't need to overreact, he surely means only about the existing
> > ice1724 sound driver for his device :)
> 
> Possibly...  it's really not clear.
> 
> > Restructuring ice1712 and ice1724 drivers to use ASoC would require
> > quite a lot of works, and no one really wants it, I guess.  Many
> > boards are old and can't be tested easily.  And, we still need to
> > match the ASoC components with the controls of the current driver.
> 
> > This was already discussed a bit, and Clemens suggested like this
> > way.
> 
> This isn't just adding something into a specific driver which fails at
> abstraction, it's adding generic code.  If it were adding something to
> the ice17xx driver then that'd be one thing but look at the subject line
> and location of the file...  this stuff should be buried inside the
> driver if it's too painful to make the driver sane.

The codes in sound/i2c are mostly oly for ice1712/ice1724 drivers
after all...  They could be used by others, but I don't think there
will be any more at this point.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/