linux-kernel - Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1334640620.27247.7.camel@cumari>
Date:	Tue, 17 Apr 2012 08:30:20 +0300
From:	Luciano Coelho <coelho@...com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-wireless@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH -next] wireless: TI wlxxx depends on MAC80211

Hi Randy,

On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote: 
> From: Randy Dunlap <rdunlap@...otime.net>
> 
> wl12xx build fails with many undefined symbol errors when MAC80211
> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> on MAC80211 (which already depends on CFG80211).
> 
> Here are a few of the many build errors:
> 

[...]

> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> Cc:	Luciano Coelho <coelho@...com>
> Cc:	linux-wireless@...r.kernel.org
> Cc:	"John W. Linville" <linville@...driver.com>
> ---

Thanks for the patch!


> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
> @@ -1,5 +1,6 @@
>  config WL12XX
>         tristate "TI wl12xx support"
> +	depends on MAC80211
>         select WLCORE

Do we really need this one? wl12xx selects WLCORE which in turn depends
on MAC80211 (with your change below).  Maybe we don't need this?


> ---help---
>  	  This module adds support for wireless adapters based on TI wl1271,
> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
> @@ -1,6 +1,6 @@
>  config WLCORE
>  	tristate "TI wlcore support"
> -	depends on WL_TI && GENERIC_HARDIRQS
> +	depends on WL_TI && GENERIC_HARDIRQS && MAC80211
>  	depends on INET
>  	select FW_LOADER
>  	---help---

-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/