linux-kernel - Re: USB storage SCSI EH oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1334735898.4410.18.camel@dabdike>
Date:	Wed, 18 Apr 2012 07:58:19 +0000
From:	James Bottomley <jbottomley@...allels.com>
To:	Jens Axboe <axboe@...nel.dk>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: USB storage SCSI EH oops

On Wed, 2012-04-18 at 09:56 +0200, Jens Axboe wrote:
> On 04/18/2012 09:53 AM, James Bottomley wrote:
> > On Sat, 2012-04-14 at 15:49 -0700, Linus Torvalds wrote:
> >> On Sat, Apr 14, 2012 at 3:29 PM, Linus Torvalds
> >> <torvalds@...ux-foundation.org> wrote:
> >>>
> >>> Confirmed.
> >>>
> >>> I tested twice: with that patch, the oops is repeatable, and happens
> >>> something like 30 seconds after plugging in the USB thing into the
> >>> monitor.
> >>>
> >>> With that patch reverted, the thing still doesn't *work*, but I don't
> >>> get the oops. Instead, I get the appended noise in my dmesg..
> >>
> >> .. and the reason that card reader has trouble seems to be that it's
> >> just too damn old, and doesn't understand SD-HC cards. It works fine
> >> with old SD cards.
> >>
> >> So the reader is fine (well, apart from being too old), USB-storage is
> >> fine, but the SCSI error handler is broken.
> >>
> >> Even with that commit reverted, once the SCSI layer has decided to
> >> off-line the device, you can't get it back, even if you remove the
> >> media and insert a non-HC SD card. You have to unplug and re-plug the
> >> reader. That seems to be a slight misfeature of SCSI error handling,
> >> but compared to oopsing, it's minor.
> > 
> > OK, will either queue the update or a revert.
> 
> Martins patch went into -git 4 days ago. Since Linus didn't follow up in
> rage, I was assuming the issue had been resolved with that.

Hm, OK ... I'm not sure currently the original patch is correct, but we
can sort that out as part of the normal process.

James