linux-kernel - Re: [PATCH V2 1/3] lib: add support for stmp-style devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Apr 2012 11:20:19 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Dong Aisheng <aisheng.dong@...escale.com>
Cc:	Huang Shijie <b32955@...escale.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>, Shawn Guo <shawn.guo@...aro.org>
Subject: Re: [PATCH V2 1/3] lib: add support for stmp-style devices

On Wed, Apr 18, 2012 at 05:05:52PM +0800, Dong Aisheng wrote:
> Hi Wolfram,
> 
> On Thu, Mar 29, 2012 at 08:43:20AM +0200, Wolfram Sang wrote:
> > Hi,
> > 
> > > >  include/linux/stmp_device.h |   20 +++++++++++
> > > IMHO, this header should be placed at include/linux/fsl/.
> > 
> > Hmm, one never knows if somewhen in the future some other vendor decides to do
> > do a device with this register layout. It is just a layout, not an IP core per
> > se. So, I'd prefer to leave it as is.
> > 
> 
> Acked-by: Dong Aisheng <dong.aisheng@...aro.org>

Thanks!

> 
> I'm converting mxs-dma driver to be mach-independent which also needs
> this patch.
> 
> Do you know when this will be merged?

Nope. I assumed it could go in via arm-soc, since it makes sense and
Arnd used to comment this series. He is probably busy, currently.

> BTW, one small question:
> Is it possible that stmp_reset_block also be used by other vendors?

Sure, why not? I could ask a friend to to do an FPGA for me with this
layout.

> If not, i guess include/linux/fsl which already exists may be the
> right place.

Which is a bad choice in my book. linux/dma would have been the proper
thing for mxs-dma.h, I'd think.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)