linux-kernel - Re: [PATCH 1/2] clk: Provide dummy clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120418095435.GX24211@n2100.arm.linux.org.uk>
Date:	Wed, 18 Apr 2012 10:54:35 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Mike Turquette <mturquette@...com>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] clk: Provide dummy clk_unregister()

On Wed, Apr 18, 2012 at 09:07:12AM +0100, Mark Brown wrote:
> +/**
> + * clk_unregister - unregister a currently registered clock
> + * @clk: clock to unregister
> + *
> + * Currently unimplemented.
> + */
> +int clk_unregister(struct clk *clk)
> +{
> +	return -EINVAL;

Don't make unregister calls return values.  Think about this situation
for a moment:

	You call an unregister function in a drivers ->remove function.
	The unregister function fails.  However, the reason the ->remove
	function is being called is because the module is being removed.
	You can't stop the module being removed once the process has
	started.  What do you do with this error?

To put it another way, if an unregister function fails, you're buggered.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/