linux-kernel - Re: [PATCH 1/2] clk: Provide dummy clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120418104857.GI3021@opensource.wolfsonmicro.com>
Date:	Wed, 18 Apr 2012 11:48:58 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Mike Turquette <mturquette@...com>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] clk: Provide dummy clk_unregister()

On Wed, Apr 18, 2012 at 10:54:35AM +0100, Russell King - ARM Linux wrote:

> Don't make unregister calls return values.  Think about this situation
> for a moment:

> 	You call an unregister function in a drivers ->remove function.
> 	The unregister function fails.  However, the reason the ->remove
> 	function is being called is because the module is being removed.
> 	You can't stop the module being removed once the process has
> 	started.  What do you do with this error?

> To put it another way, if an unregister function fails, you're buggered.

I absolutely agree, I think this is a stupid pattern for us to have
(generally the return values just get ignored...) but sadly it appears
to be the pattern that we have return values but ignore them probably
because the driver model does this.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)