linux-kernel - RE: [PATCH RESEND 1/1] Drivers: scsi: storvsc: Properly handle errors from the host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Apr 2012 12:38:05 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>,
	"ohering@...e.com" <ohering@...e.com>,
	"jbottomley@...allels.com" <jbottomley@...allels.com>,
	"hch@...radead.org" <hch@...radead.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"apw@...onical.com" <apw@...onical.com>
Subject: RE: [PATCH RESEND 1/1] Drivers: scsi: storvsc: Properly handle
 errors from the host



> -----Original Message-----
> From: KY Srinivasan
> Sent: Tuesday, April 10, 2012 11:14 AM
> To: KY Srinivasan; gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; virtualization@...ts.osdl.org; ohering@...e.com;
> jbottomley@...allels.com; hch@...radead.org; linux-scsi@...r.kernel.org;
> apw@...onical.com
> Subject: RE: [PATCH RESEND 1/1] Drivers: scsi: storvsc: Properly handle errors
> from the host
> 
> 
> 
> > -----Original Message-----
> > From: K. Y. Srinivasan [mailto:kys@...rosoft.com]
> > Sent: Thursday, April 05, 2012 3:27 PM
> > To: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> > devel@...uxdriverproject.org; virtualization@...ts.osdl.org; ohering@...e.com;
> > jbottomley@...allels.com; hch@...radead.org; linux-scsi@...r.kernel.org;
> > apw@...onical.com
> > Cc: KY Srinivasan
> > Subject: [PATCH RESEND 1/1] Drivers: scsi: storvsc: Properly handle errors from
> > the host
> >
> > If the host returns error for pass through commands, deal with them
> > appropriately. I would like to thank James for patiently helping
> > me with this patch.
> 
> James,
> 
> Thank you for suggesting the fix here. I hope this is what you were looking for.
> 
> Regards,
> 
> K. Y

Ping.

> >
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > ---
> >  drivers/scsi/storvsc_drv.c |   20 +++++++++++++++-----
> >  1 files changed, 15 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > index 83a1972..528d52b 100644
> > --- a/drivers/scsi/storvsc_drv.c
> > +++ b/drivers/scsi/storvsc_drv.c
> > @@ -785,12 +785,22 @@ static void storvsc_command_completion(struct
> > storvsc_cmd_request *cmd_request)
> >  	/*
> >  	 * If there is an error; offline the device since all
> >  	 * error recovery strategies would have already been
> > -	 * deployed on the host side.
> > +	 * deployed on the host side. However, if the command
> > +	 * were a pass-through command deal with it appropriately.
> >  	 */
> > -	if (vm_srb->srb_status == SRB_STATUS_ERROR)
> > -		scmnd->result = DID_TARGET_FAILURE << 16;
> > -	else
> > -		scmnd->result = vm_srb->scsi_status;
> > +	scmnd->result = vm_srb->scsi_status;
> > +
> > +	if (vm_srb->srb_status == SRB_STATUS_ERROR) {
> > +		switch (scmnd->cmnd[0]) {
> > +		case ATA_16:
> > +		case ATA_12:
> > +			set_host_byte(scmnd, DID_PASSTHROUGH);
> > +			break;
> > +		default:
> > +			set_host_byte(scmnd, DID_TARGET_FAILURE);
> > +		}
> > +	}
> > +
> >
> >  	/*
> >  	 * If the LUN is invalid; remove the device.
> > --
> > 1.7.4.1
> >
> >
> >



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/