linux-kernel - [PATCH] irqdomain: print a warning if domains contain IRQ 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1334756420-12019-1-git-send-email-linus.walleij@stericsson.com>
Date:	Wed, 18 Apr 2012 15:40:20 +0200
From:	Linus Walleij <linus.walleij@...ricsson.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Grant Likely <grant.likely@...retlab.ca>
Cc:	<linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: [PATCH] irqdomain: print a warning if domains contain IRQ 0

From: Linus Walleij <linus.walleij@...aro.org>

Some of the clients using IRQ domains from the ARM VIC
(arch/arm/common/vic.c) don't know that their (hardware) IRQ 0
is silently ignored by the IRQ core, they will just notice
that they're not getting this IRQ anymore. So print a warning
if a domain contains IRQ 0 (NO_IRQ) so we get some noise about
it atleast.

Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
---
 kernel/irq/irqdomain.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 0e0ba5f..1444454 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -136,8 +136,10 @@ struct irq_domain *irq_domain_add_legacy(struct device_node *of_node,
 		int hwirq = first_hwirq + i;
 
 		/* IRQ0 gets ignored */
-		if (!irq)
+		if (!irq) {
+			pr_warn("trying to register IRQ 0 (NO_IRQ) in an irq  domain\n");
 			continue;
+		}
 
 		/* Legacy flags are left to default at this point,
 		 * one can then use irq_create_mapping() to
-- 
1.7.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/