linux-kernel - Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Apr 2012 15:46:44 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Marek Szyprowski <m.szyprowski@...sung.com>
Cc:	Karol Lewandowski <k.lewandowsk@...sung.com>, ben-linux@...ff.org,
	thomas.abraham@...aro.org, linux-kernel@...r.kernel.org,
	linux-i2c@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	linux-samsung-soc@...r.kernel.org,
	Tomasz Stanislawski <t.stanislaws@...sung.com>,
	kyungmin.park@...sung.com, broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440


> > >  Optional properties:
> > > +  - gpios: The order of the gpios should be the following: <SDA, SCL>.
> > > +    The gpio specifier depends on the gpio controller. Required in all cases
> > > +    except when "samsung,i2c-no-gpio" is also specified.
> > > +  - samsung,i2c-no-gpio: input/output lines of the controller are
> > > +    permanently wired to the respective client, there are no gpio
> > > +    lines that need to be configured to enable this controller
> > 
> > Can't we just skip this property...
> 
> All standard s3c-24x0 i2c controllers require gpio lines for proper operation,
> so lack of the gpios property should be considered as an error. However there
> is a special case of internal, embedded i2c controller which has no such gpio 
> lines at all.
> 
> > >    - samsung,i2c-slave-addr: Slave address in multi-master enviroment. If not
> > >      specified, default value is 0.
> > >    - samsung,i2c-max-bus-freq: Desired frequency in Hz of the bus. If not
> > >      specified, the default value in Hz is 100000.
> > > +  - samsung,i2c-quirk-hdmiphy: Quirk for HDMI PHY block found on
> > > +    Exynos4 platform - reduce timeout and reset controller after each
> > > +    transfer
> > 
> > ... and this one, if we declare a new compatible-entry for exynos4?
> 
> It is not strictly related to Exynos4 SoCs. Exynos4 SoC has 8 standard s3c2440 style
> i2c controllers and one additional, internal controller for HDMIPHY, which needs 
> some workarounds in the driver. Maybe the quirk should be named 'broken timeout 
> detection'

I was wondering since you do what I suggested for platform devices already:

+               .name           = "s3c2440-hdmiphy-i2c",
+               .driver_data    = QUIRK_S3C2440 | QUIRK_HDMIPHY | QUIRK_NO_GPIO,

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)