linux-kernel - Re: osd_req_encode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC-hyiHfVH5C6CS43kCBQ1LO9JUN-rqxrS-UvtJQ_YyWxUWp6w@mail.gmail.com>
Date:	Wed, 18 Apr 2012 08:56:01 -0700
From:	Yehuda Sadeh Weinraub <yehuda.sadeh@...amhost.com>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Alex Elder <elder@...amhost.com>, Sage Weil <sage@...dream.net>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: osd_req_encode_op() breakage?

On Wed, Apr 18, 2012 at 8:32 AM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> On Wed, Apr 18, 2012 at 10:09:05AM -0500, Alex Elder wrote:
>
> > Yes, you are absolutely correct.
> >
> > We have obviously not done endianness checks in this code for
> > some time.
> >
> > I will commit a fix and credit you for it.  I'll also make sure
> > we are doing proper testing for this sort of thing on a regular
> > basis.
>
> FWIW, that got caught by sparse, but I would really recommend _testing_
> on big-endian - getting an emulated headless e.g. mips box is fairly
> easy with qemu; I'd done that with debian big-endian mips userland on
> emulated malta and it didn't take much work to set up.
>
> Speaking of sparse, I think we simply ought to add -D__CHECK_ENDIAN__
> to CHECKFLAGS in top-level Makefile.  It's not _that_ much noise
> these days...  Not sure which tree should that go through, though...

Definitely. I've run sparse on that code from time to time, but
completely forgot about this flag and assumed everything was ok.

Yehuda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/