linux-kernel - Re: [PATCH] HID: hid-input: default HID_BATTERY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F8EF601.1050804@goop.org>
Date:	Wed, 18 Apr 2012 10:12:33 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Matthew Garrett <mjg@...hat.com>
CC:	Josh Boyer <jwboyer@...hat.com>,
	Bastien Nocera <hadess@...ess.net>,
	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...oraproject.org,
	Richard Hughes <richard@...hsie.com>
Subject: Re: [PATCH] HID: hid-input: default HID_BATTERY_STRENGTH to no

On 04/18/2012 07:24 AM, Matthew Garrett wrote:
> On Wed, Apr 18, 2012 at 10:11:31AM -0400, Josh Boyer wrote:
>> On Wed, Apr 18, 2012 at 03:08:54PM +0100, Bastien Nocera wrote:
>>> Don't. The only bit of user-space that's broken is upower, and it's
>>> getting a fixed release shortly.
>> Matthew suggested that additional kernel patches were required to add a
>> scope parameter so upower could understand that the battery is powering
>> a device and not the system.
>>
>> Also, when did it become OK to force-enable a new feature that is
>> _known_ to not work properly on recent userspace?  That makes no sense
>> to me.
> I agree. It's a great feature, but it shouldn't be default y if 
> userspace isn't ready for it yet.

Dammit, I should have pushed harder to get the scope into the same
release.  Oh well.

Does upower trigger a shutdown/hibernation if *any* power supply is low,
or just if all of them are?  Are the failing cases ones where the BT
keyboard is the only visible power supply?

In any case, no objections to disabling it if its the only way to
prevent regressions for now.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/