linux-kernel - Re: [PATCH][Trivial] staging: vt6656: Remove some redundant casts and parentheses + other style cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Apr 2012 14:23:32 -0600
From:	Joe Perches <joe@...ches.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org,
	devel@...verdev.osuosl.org, Xi Wang <xi.wang@...il.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Forest Bond <forest@...ttletooquiet.net>
Subject: Re: [PATCH][Trivial] staging: vt6656: Remove some redundant casts
 and parentheses + other style cleanups

On Mon, 2012-04-16 at 23:20 +0200, Jesper Juhl wrote:
> This is just a small/trivial cleanup patch. It makes the following
> changes to drivers/staging/vt6656/ioctl.c:
> 
> 1. Remove some redundant casts.

drivers/staging/vt6656/wcmd.h:BOOL bScheduleCommand(void *hDeviceContext,

so you could remove the casts of the first argument too.

> diff --git a/drivers/staging/vt6656/ioctl.c b/drivers/staging/vt6656/ioctl.c
[]
> @@ -101,7 +101,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq)
>  					 WLAN_CMD_BSSID_SCAN,
>  					 abyScanSSID);
>  		else
> -			bScheduleCommand((void *) pDevice, WLAN_CMD_BSSID_SCAN, NULL);
> +			bScheduleCommand((void *)pDevice, WLAN_CMD_BSSID_SCAN, NULL);

			bScheduleCommand(pDevice, WLAN_CMD_BSSID_SCAN, NULL);
[]
> @@ -190,10 +191,9 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq)
>  		netif_stop_queue(pDevice->dev);
>  		spin_lock_irq(&pDevice->lock);
>  		pMgmt->eCurrState = WMAC_STATE_IDLE;
> -		bScheduleCommand((void *) pDevice,
> -				 WLAN_CMD_BSSID_SCAN,
> +		bScheduleCommand((void *)pDevice, WLAN_CMD_BSSID_SCAN,
>  				 pMgmt->abyDesireSSID);
		bScheduleCommand(pDevice, WLAN_CMD_BSSID_SCAN,
				 pMgmt->abyDesireSSID);
etc


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/