linux-kernel - Re: [PATCH 28/43] userns: Convert user specfied uids and gids in chown into kuids and kgid

Open Source and information security mailing list archives

Message-ID: <20120418190347.GF5186@mail.hallyn.com>
Date:	Wed, 18 Apr 2012 19:03:47 +0000
From:	"Serge E. Hallyn" <serge@...lyn.com>
To:	"Eric W. Beiderman" <ebiederm@...ssion.com>
Cc:	linux-kernel@...r.kernel.org,
	Linux Containers <containers@...ts.linux-foundation.org>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	linux-security-module@...r.kernel.org,
	Al Viro <viro@...IV.linux.org.uk>,
	linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 28/43] userns: Convert user specfied uids and gids in
 chown into kuids and kgid

Quoting Eric W. Beiderman (ebiederm@...ssion.com):
> From: Eric W. Biederman <ebiederm@...ssion.com>
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>

Acked-by: Serge Hallyn <serge.hallyn@...onical.com>

> ---
>  fs/open.c |   13 +++++++++++--
>  1 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/open.c b/fs/open.c
> index 92335f6..e166801 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -506,15 +506,24 @@ static int chown_common(struct path *path, uid_t user, gid_t group)
>  	struct inode *inode = path->dentry->d_inode;
>  	int error;
>  	struct iattr newattrs;
> +	kuid_t uid;
> +	kgid_t gid;
> +
> +	uid = make_kuid(current_user_ns(), user);
> +	gid = make_kgid(current_user_ns(), group);
>  
>  	newattrs.ia_valid =  ATTR_CTIME;
>  	if (user != (uid_t) -1) {
> +		if (!uid_valid(uid))
> +			return -EINVAL;
>  		newattrs.ia_valid |= ATTR_UID;
> -		newattrs.ia_uid = user;
> +		newattrs.ia_uid = uid;
>  	}
>  	if (group != (gid_t) -1) {
> +		if (!gid_valid(gid))
> +			return -EINVAL;
>  		newattrs.ia_valid |= ATTR_GID;
> -		newattrs.ia_gid = group;
> +		newattrs.ia_gid = gid;
>  	}
>  	if (!S_ISDIR(inode->i_mode))
>  		newattrs.ia_valid |=
> -- 
> 1.7.2.5
> 
> _______________________________________________
> Containers mailing list
> Containers@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/containers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives