linux-kernel - Re: [PATCH] ethernet: fix checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120417.225018.2141913804796063004.davem@davemloft.net>
Date:	Tue, 17 Apr 2012 22:50:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	laura@...edu.org
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	eric.dumazet@...il.com, nhorman@...driver.com
Subject: Re: [PATCH] ethernet: fix checkpatch errors

From: Laura Vasilescu <laura@...edu.org>
Date: Tue, 17 Apr 2012 17:27:24 +0300

> Signed-off-by: Laura Vasilescu <laura@...edu.org>

I'd rather have the checkpath errors than what we end up with
your changes:

> -	else if (1 /*dev->flags&IFF_PROMISC */ ) {
> -		if (unlikely(compare_ether_addr_64bits(eth->h_dest, dev->dev_addr)))
> +	else if (1 /*dev->flags&IFF_PROMISC */) {
> +		if (unlikely(compare_ether_addr_64bits(eth->h_dest,
> +							dev->dev_addr)))

This indentation is wrong, the "dev->dev_addr" argument must line up
with the first column after the openning parenthesis on the previous
line.

> -int eth_header_cache(const struct neighbour *neigh, struct hh_cache *hh, __be16 type)
> +int eth_header_cache(const struct neighbour *neigh,
> +			struct hh_cache *hh,
> +			__be16 type)

Same problem here for hh and type args.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/