linux-kernel - Re: [PATCH] serial: 8250: Add cpufreq support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120418204701.31238fe7@pyramind.ukuu.org.uk>
Date:	Wed, 18 Apr 2012 20:47:01 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Shankarmurthy, Akshay" <akshay.s@...com>
Cc:	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>,
	"jamie@...ieiles.com" <jamie@...ieiles.com>,
	"swarren@...dia.com" <swarren@...dia.com>,
	"dianders@...omium.org" <dianders@...omium.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250: Add cpufreq support

> As per my understanding, tty count keeps the count of tty_open and tty_release, that is
> how many open and close happened on the tty device file(/dev/ttyS*).
> The requirement here is a tty count check, if it is greater than zero then only it should
> proceed for further execution. 

The physical port has a different lifetime to the struct tty_struct
(which may change many times within the lifetime of the port). You can't
simply go from the port to a tty struct and assume this is safe and will
not change.

> Kindly elaborate more on the same if it's not correct.

Look at how tty_port_tty_get is used
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/