linux-kernel - Re: [PATCH 11/12] drivers: staging: rtl8172: Remove unneeded include of version.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F8F2D7F.8090905@lwfinger.net>
Date:	Wed, 18 Apr 2012 16:09:19 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Marcos Paulo de Souza <marcos.souza.org@...il.com>
CC:	linux-kernel@...r.kernel.org,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH 11/12] drivers: staging: rtl8172: Remove unneeded include
 of version.h

On 04/17/2012 11:30 PM, Marcos Paulo de Souza wrote:
> The output of "make versioncheck" told us that:
>
> drivers/staging/rtl8712/osdep_service.h: 32 linux/version.h not needed.
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c: 46 linux/version.h not needed.
>
> If we take a look at these files, we will agree to remove it.
>
> Cc: Larry Finger<Larry.Finger@...inger.net>
> Cc: Florian Schilhabel<florian.c.schilhabel@...glemail.com>
> Cc: Greg Kroah-Hartman<gregkh@...uxfoundation.org>
> Cc:<devel@...verdev.osuosl.org>
> Signed-off-by: Marcos Paulo de Souza<marcos.souza.org@...il.com>
> ---
>   drivers/staging/rtl8712/osdep_service.h       |    1 -
>   drivers/staging/rtl8712/rtl871x_ioctl_linux.c |    1 -
>   2 files changed, 0 insertions(+), 2 deletions(-)

ACKed-by: Larry Finger <Larry.Finger@...inger.net>


>
> diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h
> index 9ba6033..cabf774 100644
> --- a/drivers/staging/rtl8712/osdep_service.h
> +++ b/drivers/staging/rtl8712/osdep_service.h
> @@ -29,7 +29,6 @@
>   #define _SUCCESS	1
>   #define _FAIL		0
>
> -#include<linux/version.h>
>   #include<linux/spinlock.h>
>
>   #include<linux/interrupt.h>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index ef35bc2..a44d539 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -43,7 +43,6 @@
>   #include<linux/module.h>
>   #include<linux/kernel.h>
>   #include<linux/init.h>
> -#include<linux/version.h>
>   #include<linux/io.h>
>   #include<linux/semaphore.h>
>   #include<net/iw_handler.h>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/