lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMe9rOofzJg+Q1M8cDw0ebVLZodq_0BN=A-ytpmdHZzE9LORtg@mail.gmail.com>
Date:	Wed, 18 Apr 2012 16:54:02 -0700
From:	"H.J. Lu" <hjl.tools@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/x32] x32: Fix alignment fail in struct compat_siginfo

On Wed, Apr 18, 2012 at 4:48 PM, H. Peter Anvin <hpa@...or.com> wrote:
> On 04/18/2012 03:55 PM, H.J. Lu wrote:
>> On Wed, Apr 18, 2012 at 2:24 PM, H. Peter Anvin <hpa@...or.com> wrote:
>>> Something like this works for you?
>>>
>>> Note: we should promote __compat_[us]64 to a global type when we do the
>>> cleanup work requested by Linus (change __[us]64 to explicitly aligned
>>> types, with all users that require the old types using __compat_[us]64),
>>> but we need the compiler warning to do that, realistically.
>>>
>>
>> Can we also align struct siginfo to 8byte for x32?
>>
>
> We could.  If we want to align the substructures then we need some major
> surgery to the compat_siginfo handling though.
>

Since there will be no x32 kernel, align struct siginfo to 8byte for x32
will only be for user space code.  It shouldn't be a problem for kernel.


-- 
H.J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ