linux-kernel - Re: [PATCH 2/3] pinctrl: pinctrl-imx: add imx6q pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120418034027.GB18021@shlinux2.ap.freescale.net>
Date:	Wed, 18 Apr 2012 11:40:28 +0800
From:	Dong Aisheng <aisheng.dong@...escale.com>
To:	Stephen Warren <swarren@...dotorg.org>
CC:	Dong Aisheng-B29396 <B29396@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linus.walleij@...ricsson.com" <linus.walleij@...ricsson.com>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	Guo Shawn-R65073 <r65073@...escale.com>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>
Subject: Re: [PATCH 2/3] pinctrl: pinctrl-imx: add imx6q pinctrl driver

On Wed, Apr 18, 2012 at 04:12:50AM +0800, Stephen Warren wrote:
> On 04/13/2012 10:18 AM, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@...aro.org>
> > 
> > Signed-off-by: Dong Aisheng <dong.aisheng@...aro.org>
> 
> > diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
> 
> >  static const struct of_device_id imx_pmx_dt_ids[] = {
> > +#ifdef CONFIG_PINCTRL_IMX6Q
> > +	{ .compatible = "fsl,imx6q-iomuxc", .data = (void *) &imx6q_pinctrl_info, },
> > +#endif
> >  	{ /* sentinel */ }
> >  };
> >  MODULE_DEVICE_TABLE(of, imx_pmx_dt_ids);
> 
> Sorry for the slow review.
> 
> Based on SPEAr pinctrl review comments, we shouldn't have a single
> driver that knows about all the different SoCs that it could support,
> but rather one driver per SoC, with each of those calling into some
> utility code in the core driver to do all the probe/remove work.
> 
Sound like a good idea.

> For more details, see commit a4c0738 "pinctrl: tegra: refactor probe
> handling" in
> git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
> (in branch for-3.5/gpio-pinmux).
> 
I will check it.
Thanks for the reminder.

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/