linux-kernel - Re: [PATCH] LockD: call per-net shutdown on every global shutdown call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F8FCD20.1070103@openvz.org>
Date:	Thu, 19 Apr 2012 12:30:24 +0400
From:	Kinsbursky Stanislav <skinsbursky@...nvz.org>
To:	"bfields@...ldses.org" <bfields@...ldses.org>,
	"Trond.Myklebust@...app.com" <Trond.Myklebust@...app.com>
CC:	"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...nvz.org" <devel@...nvz.org>
Subject: Re: [PATCH] LockD: call per-net shutdown on every global shutdown
 call

Please, ignore this patch.
The idea is correct, but current implementation hides few more things to be 
modified.
Otherwise kernel oopses.
Sorry.

18.04.2012 17:18, Stanislav Kinsbursky пишет:
> Per-net LockD shutdown call must be called regardless of global nlm users
> counter.
>
> Signed-off-by: Stanislav Kinsbursky<skinsbursky@...allels.com>
>
> ---
>   fs/lockd/svc.c |    5 ++---
>   1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index 1ead075..2ad3715 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -381,10 +381,9 @@ lockd_down(struct net *net)
>   {
>   	mutex_lock(&nlmsvc_mutex);
>   	if (nlmsvc_users) {
> -		if (--nlmsvc_users) {
> -			lockd_down_net(net);
> +		lockd_down_net(net);
> +		if (--nlmsvc_users)
>   			goto out;
> -		}
>   	} else {
>   		printk(KERN_ERR "lockd_down: no users! task=%p\n",
>   			nlmsvc_task);
>


-- 
Best regards,
Stanislav Kinsbursky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/