linux-kernel - Re: [PATCH V2 2/2] staging: iio: light: isl29018: use regmap for register access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F8FE14D.6010005@metafoo.de>
Date:	Thu, 19 Apr 2012 11:56:29 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	jic23@....ac.uk, gregkh@...uxfoundation.org, max@...o.at,
	jbrenner@...sinc.com, bfreed@...omium.org, grundler@...omium.org,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/2] staging: iio: light: isl29018: use regmap for
 register access

On 04/19/2012 10:59 AM, Laxman Dewangan wrote:
> [...]
> -static int isl29018_read_sensor_input(struct i2c_client *client, int mode)
> +static int isl29018_read_sensor_input(struct isl29018_chip *chip, int mode)
>  {
>  [...]
> -		dev_err(&client->dev, "Error in reading MSB DATA\n");
> +	status = regmap_read(chip->regmap, ISL29018_REG_ADD_DATA_MSB, &msb);
> +	if (status < 0) {
> +		dev_err(chip->dev,
> +			"Error in reading MSB DATA with error %d\n", status);
>  		return msb;

should return status instead of msb.

> [...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/