linux-kernel - Re: [tip:timers/urgent] tick: Fix oneshot broadcast setup really

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Apr 2012 15:44:42 +0530
From:	Santosh Shilimkar <santosh.shilimkar@...com>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	Suresh Siddha <suresh.b.siddha@...el.com>, mingo@...nel.org,
	hpa@...or.com, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, svenjoac@....de, rjw@...k.pl,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:timers/urgent] tick: Fix oneshot broadcast setup really

Thomas,

On Thursday 19 April 2012 01:59 PM, Thomas Gleixner wrote:
> On Wed, 18 Apr 2012, Suresh Siddha wrote:
>> On Wed, 2012-04-18 at 17:31 +0200, Thomas Gleixner wrote:
>> From: Suresh Siddha <suresh.b.siddha@...el.com>
>> Subject: tick: Fix the spurious broadcast timer ticks
>>
>> During resume, tick_resume_broadcast() programs the broadcast timer
>> in oneshot mode unconditionally. On the platforms where broadcast timer
>> is not really required, this will generate spurious broadcast timer ticks
>> upon resume. For example, on the always running apic timer platforms with
>> HPET, I see spurious hpet tick once every ~5minutes (which is the 32-bit
>> hpet counter wraparound time).
>>
>> Similar to boot time, during resume make the oneshot mode setting of
>> the broadcast clock event device conditional on the state of active broadcast
>> users. 
>>
>> Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>
> 
> Sven, Santosh, can you confirm that this works for you on top of the
> other two patches?
> 
I tried this patch on top of previous changes and it continues
to work. Just to be clear on what I have tested so far, attaching
the two patches.

Regards
Santosh

View attachment "0001-tick-Fix-oneshot-broadcast-setup-really.patch" of type "text/x-patch" (3366 bytes)

View attachment "0002-tick-Fix-the-spurious-broadcast-timer-ticks.patch" of type "text/x-patch" (1420 bytes)