[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120419030432.GA23261@amt.cnet>
Date: Thu, 19 Apr 2012 00:04:32 -0300
From: Marcelo Tosatti <mtosatti@...hat.com>
To: Alex Williamson <alex.williamson@...hat.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
jbaron@...hat.com, jan.kiszka@...mens.com
Subject: Re: [PATCH] kvm: lock slots_lock around device assignment
On Tue, Apr 17, 2012 at 09:46:44PM -0600, Alex Williamson wrote:
> As pointed out by Jason Baron, when assigning a device to a guest
> we first set the iommu domain pointer, which enables mapping
> and unmapping of memory slots to the iommu. This leaves a window
> where this path is enabled, but we haven't synchronized the iommu
> mappings to the existing memory slots. Thus a slot being removed
> at that point could send us down unexpected code paths removing
> non-existent pinnings and iommu mappings. Take the slots_lock
> around creating the iommu domain and initial mappings as well as
> around iommu teardown to avoid this race.
>
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists