linux-kernel - Re: [PATCH linux-next] ipc: fix local variable initialization in compat_do_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F900C7B.3060607@openvz.org>
Date:	Thu, 19 Apr 2012 17:00:43 +0400
From:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Stanislav Kinsbursky <skinsbursky@...allels.com>,
	Arnd Bergmann <arnd@...db.de>,
	Pavel Emelianov <xemul@...allels.com>,
	Chris Metcalf <cmetcalf@...era.com>,
	Lucas De Marchi <lucas.de.marchi@...il.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH linux-next] ipc: fix local variable initialization in
 compat_do_msg_fill()

Konstantin Khlebnikov wrote:
> The "msgp" must points to the userspace buffer.
>
> fix for linux-next commit 774d0252d303969a7281eefd6eaccde50bb6eb6e
> ("c/r: ipc: message queue receive cleanup")

Oops, Dan Carpenter had caught this several days before me:
[patch] c/r: ipc: uninitialized variable in compat_do_msg_fill()

>
> Signed-off-by: Konstantin Khlebnikov<khlebnikov@...nvz.org>
> Cc: Stanislav Kinsbursky<skinsbursky@...allels.com>
> Cc: Lucas De Marchi<lucas.de.marchi@...il.com>
> Cc: Chris Metcalf<cmetcalf@...era.com>
> Cc: Cyrill Gorcunov<gorcunov@...nvz.org>
> Cc: Pavel Emelyanov<xemul@...allels.com>
> Cc: Arnd Bergmann<arnd@...db.de>
> Cc: Andrew Morton<akpm@...ux-foundation.org>
> ---
>   ipc/compat.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ipc/compat.c b/ipc/compat.c
> index 6da376b..0c2ebd0 100644
> --- a/ipc/compat.c
> +++ b/ipc/compat.c
> @@ -363,7 +363,7 @@ static long compat_do_msg_steal(void __user *dest, struct msg_msg *msg, size_t b
>
>   long compat_do_msg_fill(void __user *dest, struct msg_msg *msg, size_t bufsz)
>   {
> -	struct compat_msgbuf __user *msgp;
> +	struct compat_msgbuf __user *msgp = dest;
>   	size_t msgsz;
>
>   	if (put_user(msg->m_type,&msgp->mtype))
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/