linux-kernel - Re: [PATCH v4] i2c: Add device tree support to i2c-pnx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F903E0C.6010604@antcom.de>
Date:	Thu, 19 Apr 2012 18:32:12 +0200
From:	Roland Stigge <stigge@...com.de>
To:	Wolfram Sang <w.sang@...gutronix.de>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <robherring2@...il.com>, vitalywool@...il.com,
	khali@...ux-fr.org, ben-linux@...ff.org, rob.herring@...xeda.com,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org, arm@...nel.org,
	linux-arm-kernel@...ts.infradead.org, kevin.wells@....com,
	srinivas.bakki@....com
Subject: Re: [PATCH v4] i2c: Add device tree support to i2c-pnx.c

Hi,

On 04/19/2012 06:07 PM, Wolfram Sang wrote:
>> + - clock-frequency: desired I2C bus clock frequency in Hz,
>> Default: 100000 Hz + - pnx,timeout: I2C bus timeout in
>> milliseconds, Default: 10 ms
> 
> I'd like to repeat my question to the devicetree folks here: Can we
> have timeout generic? It doesn't make sense to me to have that per
> vendor again and again.

Sounds completely reasonable.

To help make the devicetree conversion into 3.5, I would prefer to
integrate the "vendor,timeout" as-is if a longish standardization
process would block this, considering that we luckily only have 2-3 of
such timeout definitions currently.

I'd volunteer to clean up later by preparing a patch when there is a
standard timeout defined.

If we have a solution soon, I will prepare a new version of the patch,
of course, in the next days.

>> +	i2c2: i2c@...a8000 { +		compatible = "nxp,pnx-i2c"; +		reg =
>> <0x400a8000 0x100>; +		interrupt-parent = <&mic>; +		interrupts =
>> <50 0>; +		#address-cells = <1>; +		#size-cells = <0>; +
>> clock-frequency = <0x186a0>; +		pnx,timeout = <0x64>;
> 
> Did you change this, too? Timeouts are better readable in dec :)

Right. But even when removing the "0x" in the timeout line above, it's
still hex, see Documentation/devicetree/booting-without-of.txt

Or did I get sth. wrong?

Thanks,

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/