linux-kernel - Re: [PATCH v7 1/6] Extcon (external connector): import Android's switch class and modify.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ0PZbQ2Q9p9NpJfJtAGDzNv-aq2cKswgLq5Q9op3UDJjQAG6w@mail.gmail.com>
Date:	Thu, 19 Apr 2012 11:36:45 +0900
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Arnd Bergmann <arnd@...db.de>, LKML <linux-kernel@...r.kernel.org>,
	NeilBrown <neilb@...e.de>, Randy Dunlap <rdunlap@...otime.net>,
	Mike Lockwood <lockwood@...roid.com>,
	Arve Hjønnevag <arve@...roid.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Morten CHRISTIANSEN <morten.christiansen@...ricsson.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	John Stultz <john.stultz@...aro.org>,
	Joerg Roedel <joerg.roedel@....com>, cw00.choi@...sung.com
Subject: Re: [PATCH v7 1/6] Extcon (external connector): import Android's
 switch class and modify.

On Thu, Apr 19, 2012 at 6:47 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Fri, Mar 23, 2012 at 05:52:58PM +0900, MyungJoo Ham wrote:
>> External connector class (extcon) is based on and an extension of
>> Android kernel's switch class located at linux/drivers/switch/.
>
> <snip>
>
> This patch breaks the build:
> drivers/extcon/extcon_class.c:79:6: error: redefinition of ‘extcon_set_state’
> include/linux/extcon.h:80:20: note: previous definition of ‘extcon_set_state’ was here
> drivers/extcon/extcon_class.c:170:5: error: redefinition of ‘extcon_dev_register’
> include/linux/extcon.h:67:19: note: previous definition of ‘extcon_dev_register’ was here
> drivers/extcon/extcon_class.c:214:6: error: redefinition of ‘extcon_dev_unregister’
> include/linux/extcon.h:73:20: note: previous definition of ‘extcon_dev_unregister’ was here
>
> So it obviously can't be applied to the tree :(
>
> Did you test it?
>
> Care to redo this series and send it again?
>
> greg k-h

Hello,

That error is very wierd. It implies that CONFIG_EXTCON is "not
defined" in extcon.h and CONFIG_EXTCON is "defined" in Makefile so
that extcon_class.c is compiled.

However, the patchset v8 (some bugfixes over patchset v7) that is
tested on the base of Linux 3.4-rc3 w/ and w/o CONFIG_EXTCON and has
been used with MAX77693-MUIC devices is on the way.

Thanks.


Cheers!
MyungJoo.

-- 
MyungJoo Ham, Ph.D.
Mobile Software Platform Lab, DMC Business, Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/