linux-kernel - Re: [PATCH 06/12] drivers: media: video: tlg2300: pd-video.c: Include version.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH0vN5LoFoCh0f1L01FHmSwBEq+_0RjBVPgmH48MM=FGM=djYg@mail.gmail.com>
Date:	Thu, 19 Apr 2012 16:46:37 -0300
From:	Marcos Souza <marcos.souza.org@...il.com>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Huang Shijie <shijie8@...il.com>,
	Kang Yong <kangyong@...egent.com>,
	Zhang Xiaobing <xbzhang@...egent.com>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 06/12] drivers: media: video: tlg2300: pd-video.c: Include
 version.h header

Em 19 de abril de 2012 16:39, Mauro Carvalho Chehab
<mchehab@...hat.com> escreveu:
> Em 18-04-2012 01:30, Marcos Paulo de Souza escreveu:
>> The output of "make versioncheck" told us that:
>>
>> drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
>>
>> If we take a look at the code, we can see that this file uses the macro
>> KERNEL_VERSION. So, we need this include.
>
> Nack. The right fix here is just the opposite: to remove the KERNEL_VERSION()
> call. The V4L2 core now fills it automatically, so drivers shouldn't touch on
> cap->version anymore. See the enclosed patch.
>
>>
>> Cc: Mauro Carvalho Chehab <mchehab@...radead.org>
>> Cc: Huang Shijie <shijie8@...il.com>
>> Cc: Kang Yong <kangyong@...egent.com>
>> Cc: Zhang Xiaobing <xbzhang@...egent.com>
>> Cc: <linux-media@...r.kernel.org>
>> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>
>> ---
>>  drivers/media/video/tlg2300/pd-video.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
>> index a794ae6..069db9a 100644
>> --- a/drivers/media/video/tlg2300/pd-video.c
>> +++ b/drivers/media/video/tlg2300/pd-video.c
>> @@ -5,6 +5,7 @@
>>  #include <linux/mm.h>
>>  #include <linux/sched.h>
>>  #include <linux/slab.h>
>> +#include <linux/version.h>
>>
>>  #include <media/v4l2-ioctl.h>
>>  #include <media/v4l2-dev.h>
>
> commit f8bf305b7103857708cd22b504a70ea4a08022fc
> Author: Mauro Carvalho Chehab <mchehab@...hat.com>
> Date:   Thu Apr 19 16:35:27 2012 -0300
>
>    tlg2300: Remove usage of KERNEL_VERSION()
>
>    As reported by Marcos:
>
>    On 04-18-2012 01:30, Marcos Paulo de Souza wrote:
>    > The output of "make versioncheck" told us that:
>    >
>    > drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
>    >
>    > If we take a look at the code, we can see that this file uses the macro
>    > KERNEL_VERSION.
>
>    The V4L2 core now fills it automatically, so drivers shouldn't touch on
>    cap->version anymore.
>
>    Reported by: Marcos Paulo de Souza <marcos.souza.org@...il.com>
>    Signed-off-by: Mauro Carvalho Chehab <mchehab@...hat.com>
>
> diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
> index a794ae6..bfbf9e5 100644
> --- a/drivers/media/video/tlg2300/pd-video.c
> +++ b/drivers/media/video/tlg2300/pd-video.c
> @@ -150,7 +150,6 @@ static int vidioc_querycap(struct file *file, void *fh,
>        strcpy(cap->driver, "tele-video");
>        strcpy(cap->card, "Telegent Poseidon");
>        usb_make_path(p->udev, cap->bus_info, sizeof(cap->bus_info));
> -       cap->version = KERNEL_VERSION(0, 0, 1);
>        cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_TUNER |
>                                V4L2_CAP_AUDIO | V4L2_CAP_STREAMING |
>                                V4L2_CAP_READWRITE | V4L2_CAP_VBI_CAPTURE;

Better yet :)

Thanks for the feedback Mauro!

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/