linux-kernel - Re: [PATCH] drivers/tty/amiserial.c: add missing tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F907348.9060201@suse.cz>
Date:	Thu, 19 Apr 2012 22:19:20 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Julia Lawall <Julia.Lawall@...6.fr>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/tty/amiserial.c: add missing tty_unlock

On 04/19/2012 06:12 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>
> 
> tty_unlock is used on all other exits from the function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Acked-by: Jiri Slaby <jslaby@...e.cz>

This is broken since 2008 BTW.

> ---
>  drivers/tty/amiserial.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 24145c3..6cc4358 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -1073,8 +1073,10 @@ static int set_serial_info(struct tty_struct *tty, struct serial_state *state,
>  		    (new_serial.close_delay != port->close_delay) ||
>  		    (new_serial.xmit_fifo_size != state->xmit_fifo_size) ||
>  		    ((new_serial.flags & ~ASYNC_USR_MASK) !=
> -		     (port->flags & ~ASYNC_USR_MASK)))
> +		     (port->flags & ~ASYNC_USR_MASK))) {
> +			tty_unlock();
>  			return -EPERM;
> +		}
>  		port->flags = ((port->flags & ~ASYNC_USR_MASK) |
>  			       (new_serial.flags & ASYNC_USR_MASK));
>  		state->custom_divisor = new_serial.custom_divisor;


-- 
js
suse labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/