linux-kernel - Re: [PATCH] spi/ep93xx: clean probe/remove routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120419063922.GA3437@beyadr.localdomain>
Date:	Thu, 19 Apr 2012 09:39:22 +0300
From:	Hannu Heikkinen <hannuxx@....fi>
To:	Mika Westerberg <mika.westerberg@....fi>
Cc:	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, grant.likely@...retlab.ca
Subject: Re: [PATCH] spi/ep93xx: clean probe/remove routines

On 19/04/12 09:16 +0300, Mika Westerberg wrote:
> On Wed, Apr 18, 2012 at 03:36:11PM +0300, Hannu Heikkinen wrote:
> > Use devm_* functions for managing devres resources.
> > 
> > Also use local espi_irq and remove irq variable from
> > struct ep93xx_spi.
> > 
> > Cc: mika.westerberg@....fi
> > Cc: grant.likely@...retlab.ca
> > Signed-off-by: Hannu Heikkinen <hannuxx@....fi>
> > ---
> >  drivers/spi/spi-ep93xx.c |   36 ++++++++++--------------------------
> >  1 file changed, 10 insertions(+), 26 deletions(-)
> > 
> > diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
> > index 6db2887..2c5fb81 100644
> > --- a/drivers/spi/spi-ep93xx.c
> > +++ b/drivers/spi/spi-ep93xx.c
> > @@ -114,7 +114,6 @@ struct ep93xx_spi {
> >  	struct clk			*clk;
> >  	void __iomem			*regs_base;
> >  	unsigned long			sspdr_phys;
> > -	int				irq;
> >  	unsigned long			min_rate;
> >  	unsigned long			max_rate;
> >  	bool				running;
> > @@ -1035,6 +1034,7 @@ static int __devinit ep93xx_spi_probe(struct platform_device *pdev)
> >  	struct ep93xx_spi_info *info;
> >  	struct ep93xx_spi *espi;
> >  	struct resource *res;
> > +	int espi_irq;
> 
> Since you are going to make a new version of the patch anyway, can you rename
> 'espi_irq' to just plain 'irq'?

Will do.

> After that you can add my
> 
> Acked-by: Mika Westerberg <mika.westerberg@....fi>

I will do the changes needed addressed by you and Hartley.

Thanks,
Hannu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/