linux-kernel - Re: [PATCH v5] i2c: Add device tree support to i2c-pnx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F916146.1080904@antcom.de>
Date:	Fri, 20 Apr 2012 15:14:46 +0200
From:	Roland Stigge <stigge@...com.de>
To:	Wolfram Sang <w.sang@...gutronix.de>
CC:	grant.likely@...retlab.ca, robherring2@...il.com,
	vitalywool@...il.com, khali@...ux-fr.org, ben-linux@...ff.org,
	rob.herring@...xeda.com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	arm@...nel.org, linux-arm-kernel@...ts.infradead.org,
	kevin.wells@....com, Srinivas Bakki <srinivas.bakki@....com>
Subject: Re: [PATCH v5] i2c: Add device tree support to i2c-pnx.c

Hi,

On 04/20/2012 02:09 PM, Wolfram Sang wrote:
>> Signed-off-by: Roland Stigge <stigge@...com.de> Reviewed-by: Arnd
>> Bergmann <arnd@...db.de> Acked-by: Wolfram Sang
>> <w.sang@...gutronix.de>
> 
> NACK! I said the approach of dropping "timeout" is OK, but unless I
> say "you may add my ack after changing this and that", please do
> not automatically add my ack. Doesn't hurt here, since I have to
> pick it up anyway.

Sorry - my apologies! Removing for next re-post.

>> Changes since v4: * Removed OF timeout property (to be added
>> later when there is consensus about how to call and handle it) *
>> Changed clock-frequency example to decimal
> 
> Thanks, I just noticed. Please drop (more precise: remove) the 
> "slave-addr" for the same reasons as "timeout".

OK, will do.

>> ret = request_irq(alg_data->irq, i2c_pnx_interrupt, -			0,
>> pdev->name, alg_data); +			  0, pdev->name, alg_data);
> 
> I know that checkpatch complains about this, but I'd prefer to
> avoid such changes unless the code before was really unreadable.

OK!

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/