linux-kernel - Re: [RFC PATCH v2 15/21] loop: use aio to perform io on the underlying file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F918B64.5030602@parallels.com>
Date:	Fri, 20 Apr 2012 20:14:28 +0400
From:	"Maxim V. Patlasov" <mpatlasov@...allels.com>
To:	Dave Kleikamp <dave.kleikamp@...cle.com>
CC:	Zach Brown <zab@...bo.net>, Jeff Moyer <jmoyer@...hat.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2 15/21] loop: use aio to perform io on the underlying
 file

On 04/20/2012 07:57 PM, Dave Kleikamp wrote:
>> So yeah, I'd agree that the loop code should be reworked a bit so that
>> both the filebacked and aio methods call vfs_sync() when they see
>> REQ_FLUSH.
> It's an easy fix. I don't anticipate that it will hurt performance too
> badly.

Two questions:

1. Could we use fdatasync there? (otherwise it can hurt performance very 
badly)

2. vfs_sync() is synchronous. loop_thread() will be blocked till it's 
completed. Would it be better to perform vfs_sync in another thread (to 
allow other bio-s in loop queue proceed)? Also, if there are more than 
one REQ_FLUSH bio in lo->lo_bio_list, we could call vfs_sync() only 
once. Make sense?

Thanks,
Maxim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/