linux-kernel - Re: remove unnecessary ftrace WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120420170356.GC2168@redhat.com>
Date:	Fri, 20 Apr 2012 13:03:56 -0400
From:	Dave Jones <davej@...hat.com>
To:	Linux Kernel <linux-kernel@...r.kernel.org>, laijs@...fujitsu.com,
	fweisbec@...il.com, srostedt@...hat.com, mingo@...e.hu
Subject: Re: remove unnecessary ftrace WARN_ONCE's.

On Wed, Apr 11, 2012 at 10:31:32PM -0400, Dave Jones wrote:
 > These warnings are trivially triggerable by any user, and serve no useful purpose afaics
 > Just -EINVAL and be done.
 > 
 > Signed-off-by: Dave Jones <davej@...hat.com>
 > 
 > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
 > index ed7b5d1..a745317 100644
 > --- a/kernel/trace/trace.c
 > +++ b/kernel/trace/trace.c
 > @@ -4136,13 +4136,11 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
 >  		return -ENOMEM;
 >  
 >  	if (*ppos & (PAGE_SIZE - 1)) {
 > -		WARN_ONCE(1, "Ftrace: previous read must page-align\n");
 >  		ret = -EINVAL;
 >  		goto out;
 >  	}
 >  
 >  	if (len & (PAGE_SIZE - 1)) {
 > -		WARN_ONCE(1, "Ftrace: splice_read should page-align\n");
 >  		if (len < PAGE_SIZE) {
 >  			ret = -EINVAL;
 >  			goto out;
 > --

Anyone want to pick this up, or shall I just send it to Linus myself ?

	Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/