linux-kernel - Re: linux-next: Tree for Apr 19 (zcache)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F91B3C1.5080507@linux.vnet.ibm.com>
Date:	Fri, 20 Apr 2012 14:06:41 -0500
From:	Seth Jennings <sjenning@...ux.vnet.ibm.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Nitin Gupta <nitingupta910@...il.com>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: linux-next: Tree for Apr 19 (zcache)

On 04/20/2012 11:37 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Apr 19, 2012 at 11:36:26PM -0500, Seth Jennings wrote:
>> One fix is this:
>>
>> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
>> index 3ed2c8f..7048e01 100644
>> --- a/drivers/staging/zcache/Kconfig
>> +++ b/drivers/staging/zcache/Kconfig
>> @@ -2,7 +2,7 @@ config ZCACHE
>>         bool "Dynamic compression of swap pages and clean pagecache pages"
>>         # X86 dependency is because zsmalloc uses non-portable pte/tlb
>>         # functions
>> -       depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
>> +       depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86
>>         select ZSMALLOC
>>         select CRYPTO_LZO
>>         default n
>>
>> I think this is the best way since ZCACHE is a bool and CRYPTO is the only
>> one of the dependencies that is a tristate.  This forces both ZSMALLOC and
>> CRYPTO_LZO to be builtin if ZCACHE is selected.
>>
>> Any other suggestions?
> 
> Could you do:
> 
> default y if (CRYPTO=y || ZSMALLOC=m)
> default m if (CRYPTO=m || ZSMALLOC=y)

ZCACHE is a bool and can't be built as a module.

The requirement is the if ZCACHE=y, then ZSMALLOC and
CRYPTO must also =y.

Thanks,
Seth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/