linux-kernel - Re: [PATCH 1/2] i2c-eg20t: add helper function for xfer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120420203937.GB12691@pengutronix.de>
Date:	Fri, 20 Apr 2012 22:39:37 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	Jean Delvare <khali@...ux-fr.org>, Ben Dooks <ben-linux@...ff.org>,
	Feng Tang <feng.tang@...el.com>,
	Alexander Stein <alexander.stein@...tec-electronic.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	qi.wang@...el.com, yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com
Subject: Re: [PATCH 1/2] i2c-eg20t: add helper function for xfer check

On Thu, Apr 19, 2012 at 03:38:04PM +0900, Tomoya MORINAGA wrote:
> Currently, there are the same code for xfer complete check processing.
> So, I add helper function pch_i2c_wait_for_check_xfer.
> 
> Reported-by: Wolfram Sang <w.sang@...gutronix.de>
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@...il.com>

Both applied to next, thanks for doing this! ~120 lines saved, that's
about 10%. And also way better maintainable, yay.

My checkers found some other issues, for which I will send patches in a
minute. Please have a look and test.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)