linux-kernel - Re: [PATCH 10/12] leds-atmel-pwm.c: Make pwmled_probe() _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120420143427.97c08ee5.akpm@linux-foundation.org>
Date:	Fri, 20 Apr 2012 14:34:27 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	linux-arm-kernel@...ts.infradead.org, arnd@...db.de,
	olof@...om.net, plagnioj@...osoft.com, ludovic.desroches@...el.com,
	linux-kernel@...r.kernel.org,
	Richard Purdie <richard.purdie@...uxfoundation.org>
Subject: Re: [PATCH 10/12] leds-atmel-pwm.c: Make pwmled_probe() __devinit

On Mon, 16 Apr 2012 11:20:54 +0200
Nicolas Ferre <nicolas.ferre@...el.com> wrote:

> Commit 892a884 (leds: convert led platform drivers to module_platform_driver)
> is omitting the section mismatch error: so change annotation of the probe
> function to __devinit instead of __init.
> 
> ...
>
> --- a/drivers/leds/leds-atmel-pwm.c
> +++ b/drivers/leds/leds-atmel-pwm.c
> @@ -35,7 +35,7 @@ static void pwmled_brightness(struct led_classdev *cdev, enum led_brightness b)
>   * NOTE:  we reuse the platform_data structure of GPIO leds,
>   * but repurpose its "gpio" number as a PWM channel number.
>   */
> -static int __init pwmled_probe(struct platform_device *pdev)
> +static int __devinit pwmled_probe(struct platform_device *pdev)
>  {
>  	const struct gpio_led_platform_data	*pdata;
>  	struct pwmled				*leds;

This is theoretically oopsable and the patch is probably needed in 3.4
and 3.3.x.

But you've applied it to linu-next via your own tree so I won't be
merging it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/