linux-kernel - RE: [PATCH 04/17] hpsa: suppress excessively chatty error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C508F8684F59FF47960D08B35B998FFE6563003D67@GVW1341EXA.americas.hpqcorp.net>
Date:	Fri, 20 Apr 2012 23:49:25 +0100
From:	"Shergill, Gurinder" <gurinder.shergill@...com>
To:	"Stephen M. Cameron" <scameron@...rdog.cce.hp.com>,
	"james.bottomley@...senpartnership.com" 
	<james.bottomley@...senpartnership.com>
CC:	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Gates, Matt" <matthew.gates@...com>,
	"stephenmcameron@...il.com" <stephenmcameron@...il.com>,
	"thenzl@...hat.com" <thenzl@...hat.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"mikem@...rdog.cce.hp.com" <mikem@...rdog.cce.hp.com>
Subject: RE: [PATCH 04/17] hpsa: suppress excessively chatty error messages

| -----Original Message-----
| From: linux-scsi-owner@...r.kernel.org [mailto:linux-scsi-
| owner@...r.kernel.org] On Behalf Of Stephen M. Cameron
| Sent: Friday, April 20, 2012 8:07 AM
| To: james.bottomley@...senpartnership.com
| Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Gates, Matt;
| stephenmcameron@...il.com; thenzl@...hat.com; akpm@...ux-foundation.org;
| mikem@...rdog.cce.hp.com
| Subject: [PATCH 04/17] hpsa: suppress excessively chatty error messages
| 
| From: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
| 
| Default behavior for any CHECK CONDITION excepting a few special cases is
| to print out certain parts of the sense buffer and the CDB.  Default
| behavior should be to print nothing and let the upper layers or
| applications decide what to do about these.  The same information is
| already available by setting the appropriate bits of the
| scsi_logging_level kernel parameter or via
| /proc/sys/dev/scsi/logging_level.

Makes sense.

| 
| Signed-off-by: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
| ---
|  drivers/scsi/hpsa.c |    2 +-
|  1 files changed, 1 insertions(+), 1 deletions(-)
| 
| diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index
| 906672b..fcb9fb2 100644
| --- a/drivers/scsi/hpsa.c
| +++ b/drivers/scsi/hpsa.c
| @@ -1193,7 +1193,7 @@ static void complete_scsi_command(struct CommandList
| *cp)
|  				break;
|  			}
|  			/* Must be some other type of check condition */
| -			dev_warn(&h->pdev->dev, "cp %p has check condition: "
| +			dev_dbg(&h->pdev->dev, "cp %p has check condition: "
|  					"unknown type: "
|  					"Sense: 0x%x, ASC: 0x%x, ASCQ: 0x%x, "
|  					"Returning result: 0x%x, "
| 

Few lines further down in the same function, there is another dev_warn() for SCSI errors.

       /* Problem was not a check condition
         * Pass it up to the upper layers...
         */
        if (ei->ScsiStatus) {
            dev_warn(&h->pdev->dev, "cp %p has status 0x%x "
                "Sense: 0x%x, ASC: 0x%x, ASCQ: 0x%x, "

I am wondering whether it make sense to make the same change here as well as. This will suppress logging for other SCSI status, for example BUSY, TASK SET FULL, etc.

Sunny