linux-kernel - Re: [PATCH] blackfin: fix ifdef fustercluck in mach-bf538/boards/ezkit.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201204200008.36915.vapier@gentoo.org>
Date:	Fri, 20 Apr 2012 00:08:34 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-kernel@...r.kernel.org, Sonic Zhang <sonic.zhang@...log.com>,
	Bob Liu <lliubbo@...il.com>
Subject: Re: [PATCH] blackfin: fix ifdef fustercluck in mach-bf538/boards/ezkit.c

On Wednesday 18 April 2012 23:57:18 Paul Gortmaker wrote:
> This file has lots and lots of ifdef, around structure decls
> and structure usages.

yeah.  we killed some off, and there probably is room for more, but some of the 
subsystems are not friendly to dynamic resource management, so we need some of 
the ifdefs.  SPI doesn't like it if you declare resources for different devices 
on the same CS even if you never actually use the device in question.  be nice 
if the detection could be delayed until "open" time.

> but since I had to tag the #endif with their respective #ifdef
> options to find this misplaced SPI endif, it would be silly to
> then go and delete them all.  So they stay.

Acked-by: Mike Frysinger <vapier@...too.org>
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)